[MPlayer-dev-eng] [PATCH] remove USE_LIBAVUTIL_SO usage

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Mar 1 14:17:48 CET 2007


Hello,
On Thu, Mar 01, 2007 at 02:14:09PM +0100, Baptiste Coudurier wrote:
> Reimar Döffinger wrote:
> > since my [RFC] received no real objections I'd like to propose attached
> > patch.
> > The way I see it, in the future practically every file will use
> > libavutil, using USE_LIBAVUTIL_SO ifdef just leads to a big mess.
> > Linking against dynamic libavutil should be unaffected as long as the
> > libavutil subdirectory is there.
> > I someone is against it, I'd propose one of these alternative (to be
> > implemented by whoever requests them ;-) ):
> > 1) a mplavutil.h or so that uses USE_LIBAVUTIL_SO to include the right
> > one.
> > 2) using #include <avutil.h> and using the compiler include path to make
> > it use the right one.
> 
> Im against it as a developper, since I use shared libs, which can
> benefits for ffmpeg and mplayer bin in the same time, very useful to debug.

I repeat: using shared libavutil is unaffected as long as you do not
delete the libavutil subdirectory! Assuming you dynamic libavutil is
(mostly) the same version, which is a requirement anyway.

> 3) export used by mplayer macros/funcs to public headers.

This is a completely unrelated issue! This is about not using hundreds of
#ifdefs

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list