[MPlayer-dev-eng] [PATCH] audio support for avisynth scripts

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Mar 1 13:24:55 CET 2007


Hello,
On Tue, Feb 27, 2007 at 06:50:30AM +0100, Gianluigi Tiesi wrote:
> pls note that the block that starts with:
> 
> sh_audio->wf = (WAVEFORMATEX*) malloc(sizeof(WAVEFORMATEX));
> 
> it's not cosmetics, the new block belong to an else
> that is indented +1 rather the old code and anyway the code
> is a bit different.

This is still cosmetics according to our definition.
I refuse to review this as long as the patch is larger than what a
diff -duwBb produces.
And yes, attaching would be better, as well as using FFMAX from avutil.h
instead of adding a new MAX define.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list