[MPlayer-dev-eng] mencoder problems with large video frames (in this case huffyuv)

[Øyvind Vågen Jægtnes]

Loren Merritt wrote:
> On Mon, 25 Jun 2007, Øyvind Vågen Jægtnes wrote:
>
>> But when i playback with mplayer i get errors like this:
>> Error generating huffman table, 13
>> Error while decoding frame!
>> Error generating huffman table, 13
>> Error while decoding frame!
>> Error generating huffman table, 10
>> Error while decoding frame!
>> Error generating huffman table, 47
>> Error while decoding frame!
>>
>> The number after the errors comes from me editing the line 256 in
>> libavcodec/huffyuv.c to:
>> av_log(NULL, AV_LOG_ERROR, "Error generating huffman table, %i\n", bits);
>> just to see what number it stumbles on.
>
> Wait, you're saying that
>
>     if(bits & 1){
>         av_log(NULL, AV_LOG_ERROR, "Error generating huffman table, %i\n", bits);
>         return -1;
>     }
>
> printed 10? See a problem with the arithmetic there?
>
> --Loren Merritt
>

Ok i've narrowed down the bug to a spesific patch.
Everything before patch:

r9069 | lorenm | 2007-05-19 04:32:59 +0200 (Sat, 19 May 2007) | 2 lines

change brute force search to min-heap. 3.6x faster generate_len_table,
8% faster ffvhuff encoding.

works fine (this is everything newest revision except for the huffyuv.c file).
All patches from 9069 -> now has the huffman table error.

http://193.239.155.190/random/mencoder/ are the builds we tested and
the working one
is the 9055 one.

to reproduce the error:
<+infernix> heres how i reproduce
<+infernix> mencoder  -oac pcm -nosound -o huffyuv_table_sample.avi
-ovc lavc -lavcopts vcodec=ffvhuff:vstrict=-1:pred=2:context=1
huffyuv_table_sample.264
<+infernix> mplayer -vo null huffyuv_table_sample.avi
<+infernix> at about frame 175-190 you'll see 2 or 3 errors

the huffyuv_table_sample.264 is uploaded to:
ftp://upload.mplayerhq.hu/MPlayer/incoming

--
Øyvind Jægtnes