[MPlayer-dev-eng] [PATCH] get rid of my_memcpy_pic code duplication

Michael Niedermayer michaelni at gmx.at
Sun Jun 24 21:33:01 CEST 2007


Hi

On Sun, Jun 24, 2007 at 02:58:09PM +0200, Reimar Döffinger wrote:
> Hello,
> Seems rather stupid that each filter has this filter copy-and-pasted
> (esp. since they also do void * arithmetic).
> I have not properly benchmarked it, but I don't think there is even a
> real need for those functions to be static inline at all.
> Ok to apply?

IMHO yes but i think my_memcpy_pic() should be renamed after that, its name is
not really related to the difference to memcpy_pic()

also i would rename forceskip to limit2width

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070624/63aef9f1/attachment.pgp>


More information about the MPlayer-dev-eng mailing list