[MPlayer-dev-eng] [PATCH] simplify/correct subtitle selection

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Jun 24 10:10:34 CEST 2007


Hello,
On Sun, Jun 17, 2007 at 10:56:02AM +0200, Reimar Doeffinger wrote:
> I have not properly tested attached patch, so feel free to flame me ;-)
> But I think something like this makes sense because
> 1) current code does not work right with demuxers that detect streams
> only during playback (e.g. vobs), see also
> no_subs_displayed_past_sid0.VOB in incoming.
> 2) The change would make sure behaviour is more consistent with the ID_
> messages
> 3) The resulting code is simpler.
> 
> There is at least one bug remaining somewhere: with the
> no_subs_displayed_past_sid0.VOB sample using 'j' to switch channels
> always results in no output. I do not know for sure where the problem
> lies yet, though the demuxer seems to demux the correct stream...

This problem is unrelated and has already been fixed.
So applied.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list