[MPlayer-dev-eng] [PATCH] mkv: remove ->sub->sh malloc hack and possible memleak

[Aurelien Jacobs]

On Sat, 23 Jun 2007 19:25:46 +0200
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> Hello,
> this patch removes a hack that mallocs demuxer->sub->sh and memcpys the
> contents over instead of just setting it to some demuxer->s_streams.
> This reduces the size of the track struct, probably should fix a memleak
> (though valgrind can't find any with the old code, but neither can it
> find a double free with the new code... Hm, still some bugs left to
> fix) and should allow to get rid of the special-case code for mkv track
> switching.
> Ok to apply?

Looks OK. (but I only gave it a very quick look)

Aurel