[MPlayer-dev-eng] [PATCH] mkv: use sh_sub_t argument instead of mkv_track_t where possible

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Jun 23 19:06:21 CEST 2007


Hello,
On Wed, Jun 20, 2007 at 07:55:23PM +0200, Aurelien Jacobs wrote:
> On Wed, 20 Jun 2007 18:36:08 +0200
> Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > attached patch removes some useless clutter in the form of "t->" and
> > makes it also easier to fix how demuxer->sub->sh is set (it should be
> > set to one of the pointers in s_streams not malloc, esp. when it never
> > gets freed).
> > It also makes it easier to see what kind of "side effects" the functions
> > have.
> 
> This looks fine to me.

Applied, and a bugfix right afterwards.
Have you answered just out of interest or did you somehow become
maintainer for mkv demuxer? If so, please fix MAINTAINERS accordingly...

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list