[MPlayer-dev-eng] [PATCH] correct teletext-option in configure

Vladimir Voroshilov voroshil at gmail.com
Thu Jun 21 03:04:25 CEST 2007


2007/6/21, Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Wed, Jun 20, 2007 at 11:43:11PM +0300, Uoti Urpala wrote:
> > On Thu, 2007-06-21 at 00:11 +0700, Vladimir Voroshilov wrote:
> > > I didn't revert it yet because i was too busy developing another
> > > standalone version (without libzvbi), based on Michael's code.
> > >
> > > I'll revert r23530 in about 24 hours.
> >
> > Does the new version change so much that it's worthwhile to revert the
> > previous version before committing it? If there are lots of places where
> > you'd revert the first change and then commit the same code back then it
> > might be better not to do the revert part.
>
> Why, did someone already review the previous code? Also the patch seems to
> be against the current code and it doesn't look like that much code is shared.
>

Only routines related to interaction with mlplayer core are kept.
Changed rendering code, dropped out spu rendering ("text" teletext
mode, using osd,  was much improoved). And patch against current code
is even less readable than original teletext patch.

P.S. and yes, posted patch is currently v4l2 only. i wanted to get
working solution at least for v4l2 to continue porting into v4l and
bt848.

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719



More information about the MPlayer-dev-eng mailing list