[MPlayer-dev-eng] [PATCH] Allow to set network timeout

[Carl Eugen Hoyos]

Hi Reimar!

Reimar Doeffinger wrote:
> Hello,
> On Wed, Jun 20, 2007 at 11:05:57AM +0200, Carl Eugen Hoyos wrote:
>> On 2007-06-18 13:28, Dominik 'Rathann' Mierzejewski wrote:
>>> On Monday, 18 June 2007 at 10:53, cehoyos wrote:
>>>> Author: cehoyos
>>>> Date: Mon Jun 18 10:53:53 2007
>>>> New Revision: 23574
>>>>
>>>> Log:
>>>> Stop playing at eof or if no data arrives for ten seconds.
>>> Please make the timeout configurable.
>> Attached is a patch that allows to configure the network timeout.
>>
>> I won't apply unless someone approves it.
> 
> If it gets such a generic name it probably should also affect the
> call that sets sockopt timeout.

I completely agree, but I think that belongs to another patch (and maybe
the respective maintainer).

[...]

> How about simplifying this in the current code first:
>> int delay = 10000000;
>> if (bufferQueue->prevPacketPTS > 0.95 * rtpState->mediaSession->playEndTime())
>>   delay /= 10;

Applied. Is there a global variable that tells the code if mplayer or
mencoder were called so I can remove the division for mencoder?

>> +.B \-network-timeout (LIVE555 only)
>> +Set network timeout. When 95% are played, a thenth is used.
>> +.
>> +.TP
> 
> This so not parses for me. The German variant is almost understandable,
> but only almost too ;-)
> Also it is not entirely correct 1 / 1.05 != 0.95.

Tried to improve.

New patch attached.

Thank you for reviewing, Carl Eugen

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patchtimeout
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070620/53e4b28b/attachment.txt>