[MPlayer-dev-eng] r23257 breaks asf playback due to making get_ext_stream_properties errors criticalk

John Donaghy johnfdonaghy at gmail.com
Mon Jun 18 19:13:15 CEST 2007


> >
> >>Hello,
> >>For details please see bugzilla #843
> >>(http://bugzilla.mplayerhq.hu/show_bug.cgi?id=843).
> >>Someone who knows the code please fix it.
> >>
> >

I believe the attached patch fixes the problem. I've recreated what
seems to be the same issue on an asf sample I have here and verified
that the patch corrects it. In any case this patch addresses a problem
which needs to be fixed.

The issue is that get_ext_stream_properties shouldnt be returning
false when no extended stream properties are found for the stream in
question because that is not an error condition ... extended stream
properties are optional. The only time this function should return
false is when the buffer overrun checks fail.

John
-------------- next part --------------
A non-text attachment was scrubbed...
Name: asf_invalid_header_fix.patch
Type: application/octet-stream
Size: 285 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070618/81c17586/attachment.obj>


More information about the MPlayer-dev-eng mailing list