[MPlayer-dev-eng] Per-file -loop option reset brokenness

[Uoti Urpala]

On Fri, 2007-06-15 at 20:14 +0300, Ivan Kalvachev wrote:
> 2007/6/15, Uoti Urpala <uoti.urpala at pp1.inet.fi>:
> > If nobody here is aware of any current use which would rely on this
> > option-reset functionality I'll remove it soon and see if that makes any
> > users complain.
> 
> Show us the code.

If you mean the code I intend to remove, it's essentially one function
call:

--- a/mplayer.c
+++ b/mplayer.c
@@ -3540,9 +3540,6 @@ if(step_sec>0) {
 
   /* Looping. */
   if(mpctx->eof==1 && loop_times>=0) {
-    int l = loop_times;
-    play_tree_iter_step(mpctx->playtree_iter,0,0);
-    loop_times = l;
     mp_msg(MSGT_CPLAYER,MSGL_V,"loop_times = %d, eof = %d\n",
loop_times,mpctx-
>eof);


The play_tree_iter_step call resets the option variables. The loop_times
option is kept in another variable during the call because after
initialization it's used as a decreasing counter for remaining loop
times, but would get reset too. Apparently the need to add this
workaround for the loop option itself wasn't originally enough to make
people realize there would be similar problems with other options...