[MPlayer-dev-eng] [PATCH] Audio balance feature

[Zuxy Meng]

Hi,

2007/6/14, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Thu, Jun 14, 2007 at 08:01:01PM +0800, Zuxy Meng wrote:
> > 2007/6/14, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > > Hmm... what do you think about adding a AF_CONTROL_BALANCE?
> >
> > A new filter control command or a new filter?
>
> Only control. A simple first implementation could e.g. ake af_pan only
> accept it if nch == 0.

So we can simply use af_control_any_rev instead of storing the pointer
to the pan filter that this feature is using? Sounds good:-)

>
> > > Even if we start with a trivial implementation now, I think it would
> > > make it much simpler to extend it to work
> > > 1) when the number of channels changes (actually your approach simply
> > > does not work right if channels setup where pan is inserted contains
> > > rear channels).
> >
> > Only FL and FR are affected; other channels will simply pass thru.
>
> Yes, that's exactly what I meant - well, maybe that behaviour is
> intentional, then it's only weird, not wrong ;-)

Well, the problem is that you don't know where rear channels are. By
tradition channel 0 and 1 are FL and FR respectively, but there isn't
a standard definition for channels beyond them.

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6