[MPlayer-dev-eng] [PATCH] Audio balance feature

[Zuxy Meng]

Hi,

2007/6/14, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Thu, Jun 14, 2007 at 07:22:04PM +0800, Zuxy Meng wrote:
> > 2007/6/13, Zuxy Meng <zuxy.meng at gmail.com>:
> > >2007/5/30, Zuxy Meng <zuxy.meng at gmail.com>:
> > >> Attached patch implements the audio balance feature commonly present
> > >> in other players by using the pan audio filter. With this patch a user
> > >> can adjust the balance between the two front channels during play with
> > >> '(' and ')'.
> > >>
> > >> Comments and testing welcome!
> > >
> > >This is the latest patch against svn head.  Pls help review it to see
> > >if it can be applied.
> >
> > Fixed a bug when switching audio.
>
> Hmm... what do you think about adding a AF_CONTROL_BALANCE?

A new filter control command or a new filter?

> Even if we start with a trivial implementation now, I think it would
> make it much simpler to extend it to work
> 1) when the number of channels changes (actually your approach simply
> does not work right if channels setup where pan is inserted contains
> rear channels).

Only FL and FR are affected; other channels will simply pass thru.
> 2) would potentially allow to detect and use a filter inserted at a
> specific place in the chain for balance control by the user via -af


-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6