[MPlayer-dev-eng] [PATCH] Do not allow to compile gui without PNG_DECODER

Diego Biurrun diego at biurrun.de
Wed Jun 13 10:43:56 CEST 2007


On Wed, Jun 13, 2007 at 01:45:33AM +0200, Carl Eugen Hoyos wrote:
> 
> Attached patch stops users from trying to compile with gui, but without
> png decoder in libavcodec.
> 
> Please comment, Carl Eugen
> 
> --- configure	(Revision 23550)
> +++ configure	(Arbeitskopie)
> @@ -6997,7 +6997,9 @@
>  
>    # Required libraries
> -  test "$_libavcodec" != yes && die "The GUI requires libavcodec with PNG support."
> +  if test "$_libavcodec" != yes || test "`echo $_libavdecoders`" = "`echo $_libavdecoders | sed -e s/PNG_DECODER//`" ; then

I think this can be slightly simplified like this:

  if test "$_libavcodec" != yes || not `echo $_libavdecoders | grep PNG_DECODER > /dev/null 2>&1` ; then

Break the line at an appropriate place and the patch is good to go.

Diego



More information about the MPlayer-dev-eng mailing list