[MPlayer-dev-eng] [PATCH] af_pan.c: Avoid zero output channels when reinit af pan

[Zuxy Meng]

Hi,

2007/6/11, Zuxy Meng <zuxy.meng at gmail.com>:
> Hi,
>
> 2007/6/11, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > Hello,
> > On Mon, Jun 11, 2007 at 08:32:22AM +0800, Zuxy Meng wrote:
> > [...]
> > > @@ -48,7 +50,11 @@
> > >        ((af_data_t*)arg)->bps = af->data->bps;
> > >        return AF_FALSE;
> > >      }
> > > -    return control(af,AF_CONTROL_PAN_NOUT | AF_CONTROL_SET, &af->data->nch);
> > > +
> > > +    if (s->nch)
> > > +      return control(af,AF_CONTROL_PAN_NOUT | AF_CONTROL_SET, &af->data->nch);
> > > +    else
> > > +      return AF_OK;
> >
> > Please don't add an extra line. And actually that control call is
> > completely pointless, it is a NOP always, just return AF_OK directly.
>
> Hmm...what about other parts? And what about making pan reentrant?
> There seems to be no problem in having more than one pan filters in
> the chain after some testing.

How about these two? One to address this problem, the other makes pan reentrant.
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: af_pan.c.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070613/462fa8b0/attachment.asc>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: af_pan.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070613/462fa8b0/attachment.txt>