[MPlayer-dev-eng] [PATCH] af_pan.c: Avoid zero output channels when reinit af pan

Reimar Doeffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Jun 11 10:05:23 CEST 2007


Hello,
On Mon, Jun 11, 2007 at 08:32:22AM +0800, Zuxy Meng wrote:
[...]
> @@ -48,7 +50,11 @@
>        ((af_data_t*)arg)->bps = af->data->bps;
>        return AF_FALSE;
>      }
> -    return control(af,AF_CONTROL_PAN_NOUT | AF_CONTROL_SET, &af->data->nch);
> +
> +    if (s->nch)
> +      return control(af,AF_CONTROL_PAN_NOUT | AF_CONTROL_SET, &af->data->nch);
> +    else
> +      return AF_OK;

Please don't add an extra line. And actually that control call is
completely pointless, it is a NOP always, just return AF_OK directly.

Greetings,
Reimar Doeffinger



More information about the MPlayer-dev-eng mailing list