[MPlayer-dev-eng] [PATCH] af_pan.c: Avoid zero output channels when reinit af pan

Zuxy Meng zuxy.meng at gmail.com
Mon Jun 11 01:56:19 CEST 2007


Hi,

2007/6/11, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sun, Jun 10, 2007 at 07:16:23PM +0200, Reimar Doeffinger wrote:
> > On Sun, Jun 10, 2007 at 07:04:57PM +0800, Zuxy Meng wrote:
> > [...]
> > > I got tired about this issue.  All I want is an audio filter used for
> > > balancing that can be 'af_add()'ed at runtime and doesn't alter the #
> > > of channels before and after it. If one day you come up with an ideal
> > > solution, pls kindly ping me.
> >
> > You'd only have to add nch to af_pan_t, set that in the comamndline
> > control and on reinit read it end set af->data->nch to it if it's
> > non-zero or to the current number of channels otherwise.
>
> As in attached patch. As my development machines are all dead currently
> I can't test beyond compilation.
> If it is somehow possible to use this feature from the command line it
> should be documented, too.

Looks pretty good. But if s->nch, maybe we shouldn't call
control(af,AF_CONTROL_PAN_NOUT | AF_CONTROL_SET...) in REINIT any
more.

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6



More information about the MPlayer-dev-eng mailing list