[MPlayer-dev-eng] [PATCH] Disable optimizations when compiling with icc

[Carl Eugen Hoyos]

Hi!

Reimar Doeffinger <Reimar.Doeffinger <at> stud.uni-karlsruhe.de> writes:

> On Sun, Jun 10, 2007 at 11:06:54AM +0000, Carl Eugen Hoyos wrote:
> > Reimar Doeffinger <Reimar.Doeffinger <at> stud.uni-karlsruhe.de> writes:
> [...]
> > > I guess it will have weird effects with runtime cpudetection.

I don't think runtime cpudetection makes any sense if you can't compile mmx and
friends.

[...]

> > > IMO print a big warning that recommends using --target=generic-linux
> > 
> > How should target=generic-linux help? Would that deactivate optimizations in
> > libswscale, liba52 and mp3lib?
> 
> It will just behave as if you were compiling MPlayer on some unknown
> architecture. That means pure C code. It might be suboptimal because it
> will also not set e.g. FAST_UNALIGNED.

I understand your point now insofar as target=generic-linux actually disables
mmx etc. But since it also disables win32 libs (and others as you mentioned),
it's definitely the worse option.
Additionally, it does not help with liba52 and mp3lib.

I think icc might be a good alternative and if we don't start to support it
(even if not working perfectly) we'll never get it working.

Carl Eugen