[MPlayer-dev-eng] [PATCH] A new "balance" filter

[Reimar Doeffinger]

Hello,
On Mon, Jun 11, 2007 at 01:37:49AM +0800, Zuxy Meng wrote:
> 2007/6/11, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > On Mon, Jun 11, 2007 at 12:54:59AM +0800, Zuxy Meng wrote:
> > > As discussed with Reimar, due to subtle semantic problems existing pan
> > > filter cannot be used to implement the audio balance feature, so I've
> > > simply added a new filter, mostly based on pan code.
> >
> > Sorry, but I think this is the most bloated approach at avoiding a
> > global variable ever (which basically is all the difference to your
> > previous patch)...
> 
> Indeed. But it has the additional benefit that balancing can be used
> together with pan.

There is no "additional". If that did not work before your patch simply
had a bug. And this way is still a horribly bloated way to fix that bug.

Greetings,
Reimar Doeffinger