[MPlayer-dev-eng] [PATCH] Disable additional optimization if compiler doesn't support __attribute__((used))

Reimar Doeffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Jun 10 11:09:16 CEST 2007


Hello,
On Sun, Jun 10, 2007 at 03:41:46AM +0200, Carl Eugen Hoyos wrote:
> Attached patch disables optimizations in liba52 and mp3lib if compiler
> (icc) doesn't support __attribute__((used)).

First, you must use the MANGLE macros in the asm code, otherwise it will
fail.
Secondly ICC ignores this attribute instead of giving an error, so it's
a compiler bug IMO and I think it's a bit too much code for working
around a compiler bug.
And lastly, does doing it this way have a real advantage over
--target=generic-linux (btw. the win32 loader can still be compiler with
this option ;-) )

Greetings,
Reimar Doeffinger



More information about the MPlayer-dev-eng mailing list