[MPlayer-dev-eng] Per-file -loop option reset brokenness

Uoti Urpala uoti.urpala at pp1.inet.fi
Sat Jun 9 20:43:35 CEST 2007


When using -loop as a per-file option it's implemented as a seek back to
the start of the file, and the code also resets option variables when it
does the seek. Resetting the variables like that in the middle of
playback is wrong; it skips sanity checks which would normally be run in
initialization code, and changing the values might also require running
code.

Is it OK to simply remove that option reset functionality, or does
someone rely on some part of it? If there are a few options that should
reset in typical use then those could be handled. With the current
architecture it is not practical to implement correct reset of all
options.

Note that this does not affect global -loop, which is handled as a kind
of playlist: instead of seeking, the playback ends and is then restarted
from scratch. Such restart still resets all options.




More information about the MPlayer-dev-eng mailing list