[MPlayer-dev-eng] [PATCH] Only use -Wdeclaration-after-statement with gcc

Carl Eugen Hoyos cehoyos at ag.or.at
Fri Jun 8 09:44:23 CEST 2007


Hi!

Diego Biurrun <diego <at> biurrun.de> writes:

> > --- configure   (Revision 23501)
> > +++ configure   (Arbeitskopie)
> >  <at>  <at>  -7394,10 +7394,12  <at>  <at> 
> > +if test "$cc_vendor" = "gnu" ; then
> >  if cc_check -Wdeclaration-after-statement ; then
> >    CFLAGS="-Wdeclaration-after-statement $CFLAGS"
> >  fi
> >  cc_check -Wno-pointer-sign && CFLAGS="-Wno-pointer-sign $CFLAGS"
> > +fi
> 
> I don't think this is necessary, cc_check should fail if the compiler
> does not support these options...

Unfortunately, it doesn't fail if the compiler just warns about not
understanding the option. This leads to very ugly output.

Carl Eugen






More information about the MPlayer-dev-eng mailing list