[MPlayer-dev-eng] [PATCH] support for mov yuv2 fourcc

[Michael Niedermayer]

Hi

On Thu, Jun 07, 2007 at 09:57:55PM +0200, Reimar Döffinger wrote:
> Hello,
> On Thu, Jun 07, 2007 at 09:41:14PM +0200, Diego Biurrun wrote:
> > On Thu, Jun 07, 2007 at 08:35:56PM +0200, Reimar Döffinger wrote:
> > > On Thu, Jun 07, 2007 at 08:30:39PM +0200, Alban Bedel wrote:
> > > > On Thu, 7 Jun 2007 19:23:55 +0200
> > > > Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > > > > yuv2 seems to be some format similar to yuy2 but with unsigned chrome (very weird).
> > > > > Attached patch makes it play (sample at
> > > > > http://samples.mplayerhq.hu/mov/yuv2.mov).
> > > > > Does it look okay?
> > > > 
> > > > Simple but perhaps a bit hackish. Would it be that hard to add support for
> > > > unsigned chroma in sws ?
> > > 
> > > I do not intend to touch swscale as long as it's such a mess...
> > 
> > What's so bad about it?  (Michael is listening ;))

IIRC swscale started from a small yv12 -> rgb conerter originally writen by
arpi it evolved over time and slowly become messier
that makes it nicely fit in mplayer ;)

still i think swscales architecture is well written it just needs some
cosmetic changes to be more readable and some other minor fixes


> 
> No matter what you do, you will search at least half an hour for the
> right function in a chaotic of function that do almost the same and have
> almost the same name and completely unrelated functions in one file and
> huge functions, switch-cases and if-then-else mazes.
> Now, maybe this really can't be done much better but I hope it just
> needs someone doing some cleanup-gruntwork...

you want to volunteer to clean it up? :)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070607/506ab87b/attachment.pgp>