[MPlayer-dev-eng] [PATCH] possibly wrong use of tr in vidix check

[Alban Bedel]

On Thu, 7 Jun 2007 16:33:05 +0300
Ismail Dönmez <ismail at pardus.org.tr> wrote:

> On Thursday 07 June 2007 01:44:29 Nico Sabbi wrote:
> > tr seems to be used incorrectly in the vidix check in configure.
> > Attached patch fixes my problem (untranslated lowercases).
> > If no one objects I'll commit it tomorrow.
> >
> > 	Nico
> 
> Makes no difference here :
> 
> [~]> echo abc | tr [a-z] [A-Z]
> ABC
> 
> [~]> echo abc | tr '[a-z]' '[A-Z]'
> ABC
> 
> [~]> tr --version
> tr (GNU coreutils) 6.9

It will do a difference if there is a file with a one letter name. If there
is for ex. a file named 'b' in the directory the first form will expand to
"tr 'b' '[A-Z]'" and "echo abc | tr [a-z] [A-Z]" will give "a[b".
Note that the [] are part of the set with GNU tr, so ideally they could be
removed (ie. tr 'a-z' 'A-Z'). However i don't know how portable such a form
is.

	Albeu