[MPlayer-dev-eng] [PATCH] af_pan.c: Avoid zero output channels when reinit af pan

[Reimar Döffinger]

Hello,
On Thu, Jun 07, 2007 at 07:00:51PM +0800, Zuxy Meng wrote:
> 2007/6/7, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
[...]
> > I don't think it's really the right solution, but a proper one might not
> > be worth the effort. Though you might consider if initializing the nch
> > to 1 during filter creation isn't the better (and simpler) solution.
> 
> I don't think it simpler; they're both conditional assignments. And at
> least it makes life harder for the audio balance feature :-)

Huh? Why would you have to make setting
af->data->nch = 1;
conditional in af_open? And why would it make audio balance harder?

> I can't judge if it's better, but IMHO not to change the number of
> output is simply no worse.

It makes the behaviour somewhat non-consistent, e.g. assume MPlayer
probing support of the filter chain for number of channels.
With your proposed patch af_pan output gets "stuck" to a number of
output channels depending on the order in which you probe.
One possibility would be to store the parsed nch value some place else
so it won't get overwritten on reinit.

Greetings,
Reimar Döffinger