[MPlayer-dev-eng] [PATCH] Make mp3lib SIMD optimizations work on AMD64, the Finale

Zuxy Meng zuxy.meng at gmail.com
Thu Jun 7 03:42:12 CEST 2007


Hi,

2007/6/6, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Wed, Jun 06, 2007 at 05:11:59PM +0800, Zuxy Meng wrote:
> [...]
> >  SRCS_COMMON = sr1.c
> > +ifeq ($(TARGET_ARCH_X86),yes)
> > +SRCS_COMMON-$(TARGET_MMX)     += decode_MMX.c
> > +SRCS_COMMON-$(TARGET_SSE)     += dct64_sse.c
> > +endif
>
> Is the TARGET_ARCH_X86 check really needed? I'd say TARGET_MMX or
> TARGET_SSE implies it...

Sure they aren't needed. Hence the improved patch.

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: decode_MMX.c.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070607/4175199b/attachment.asc>


More information about the MPlayer-dev-eng mailing list