[MPlayer-dev-eng] [PATCH] Audio balance feature

Zuxy Meng zuxy.meng at gmail.com
Tue Jun 5 14:13:26 CEST 2007


Hi,

2007/6/5, Diego Biurrun <diego at biurrun.de>:
> On Tue, Jun 05, 2007 at 05:38:15PM +0800, Zuxy Meng wrote:
> >
> > 2007/6/5, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > >On Tue, Jun 05, 2007 at 09:13:28AM +0800, Zuxy Meng wrote:
> > >> Will apply this weekend of no one objects.
> > >
> > >The indentation seems inconsistent, please check it before applying.
> >
> > See if this is better.
>
> No, it's horrible, you are mixing tabs and spaces.  Also, not adding
> trailing whitespace is a plus.

Tabs are used only if the original file used them already. Doesn't the
rule say that we shall try to follow existing coding style? And I'll
remove the trailing whitespace introduced by the patch (only one place
I guess).
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6



More information about the MPlayer-dev-eng mailing list