[MPlayer-dev-eng] [PATCH] do not center GUI message boxes since that crashes with nontrusted X connection

Reimar Doeffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Jun 5 14:09:01 CEST 2007


Hello,
attached patch does this.
Unfortunately I have not found a way to detect if we are a trusted X client
or not, which would allow for a more proper solution :-(.
For me working with untrusted connections is more relevant than the
position of the message boxes, but please speak up if you find this
important enough to keep.

Greetings,
Reimar Doeffinger
-------------- next part --------------
Index: gui/mplayer/gtk/mb.c
===================================================================
--- gui/mplayer/gtk/mb.c	(revision 23461)
+++ gui/mplayer/gtk/mb.c	(working copy)
@@ -45,7 +45,8 @@
  gtk_object_set_data( GTK_OBJECT( MessageBox ),"MessageBox",MessageBox );
  gtk_widget_set_events( MessageBox,GDK_EXPOSURE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK | GDK_VISIBILITY_NOTIFY_MASK );
  gtk_window_set_title( GTK_WINDOW( MessageBox ),"MPlayer ..." );
- gtk_window_set_position( GTK_WINDOW( MessageBox ),GTK_WIN_POS_CENTER );
+// this is not overly useful and causes a crash with untrusted X forwarding
+// gtk_window_set_position( GTK_WINDOW( MessageBox ),GTK_WIN_POS_CENTER );
  gtk_window_set_modal( GTK_WINDOW( MessageBox ),TRUE );
  gtk_window_set_policy( GTK_WINDOW( MessageBox ),TRUE,TRUE,FALSE );
  gtk_window_set_wmclass( GTK_WINDOW( MessageBox ),"Message","MPlayer" );


More information about the MPlayer-dev-eng mailing list