[MPlayer-dev-eng] [PATCH] mp3lib: Align output so that movaps can be used instead of movups

[Reimar Doeffinger]

Hello,
On Tue, Jun 05, 2007 at 09:06:07AM +0800, Zuxy Meng wrote:
> > > 2. storing those temporary variables as non-static is actually faster.
> > > (possibly due to better data locality?)
> >
> > Is it also faster after the alignment part of the patch?
> 
> Of course. Together they bring about ~2.5% speed up. This alone
> contributes about 1%. All measured with ffmpeg's
> START_TIMER/STOP_TIMER macro.

IMO feel free to apply in two parts (whichever order you prefer). Fixes for crashes
should not be part of performance-improvement patches, even if it
improves performance as a side-effect :-).

> > How about aligning by 64 bytes instead of 16?
> 
> Err...my binuils can't do that.

No problem, I was just curious.

Greetings,
Reimar Doeffinger