[MPlayer-dev-eng] [PATCH] change demux_mov.c to use stream_skip instead of stream_seek

elupus elupus at ecce.se
Mon Jun 4 22:36:01 CEST 2007


Hi,

This patch changes demux_mov.c to use stream_skip's instead of stream_seeks 
to move about in stream, this makes it abit more robust on http streams 
where server doesn't support seeks. Using stream_seek instead could make 
demuxer crash when cache was low, as that would then force it to attempt a 
seek.

It also makes sure demuxer checks return value of the seek commands and 
bails out if it fails. demuxer would end up in a broken loop

One thing to note could be that this might make it a tiny bit slower on 
filesystems where seeks are very inexpensive and the mov files is read in 
some odd non linear faction, but reading 2*STREAM_BUFFER_SIZE on those 
filesystems probably won't be much slower.

/Joakim

PS. This patch relies on the fix for stream_skip for it to work
-------------- next part --------------
A non-text attachment was scrubbed...
Name: demux_mov.patch
Type: application/octet-stream
Size: 1925 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070604/11693b3b/attachment.obj>


More information about the MPlayer-dev-eng mailing list