[MPlayer-dev-eng] [PATCH] mp3lib: Align output so that movaps can be used instead of movups

Uoti Urpala uoti.urpala at pp1.inet.fi
Mon Jun 4 20:29:19 CEST 2007


On Mon, 2007-06-04 at 19:46 +0200, Reimar Döffinger wrote:
> global visibility??). Also by just removing it you are making them stack
> variables, and gcc definitely doesn't guarantee alignment for these
> either. So this is only a reason to make them global (though like that

gcc does guarantee alignment for stack variables. You're probably
thinking of the case where mixing compilers causes problems (code from
another compiler misaligns the stack on win32, while gcc relies on it
staying aligned) but I think compiling parts of MPlayer with different
compilers is an unlikely scenario. The situation is somewhat different
for FFmpeg which is designed to be called as a library from outside
code.




More information about the MPlayer-dev-eng mailing list