[MPlayer-dev-eng] [PATCH] af_pan.c: Avoid zero output channels when reinit af pan

[Zuxy Meng]

Hi,

2007/6/3, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Wed, May 30, 2007 at 10:49:27PM +0800, Zuxy Meng wrote:
> [...]
> > Index: libaf/af_pan.c
> > ===================================================================
> > --- libaf/af_pan.c    ?????? 23404??
> > +++ libaf/af_pan.c    ????????????
> > @@ -35,6 +35,8 @@
> >      // Sanity check
> >      if(!arg) return AF_ERROR;
> >
> > +    if (af->data->nch == 0)
> > +      af->data->nch = ((af_data_t*)arg)->nch;
>
> IMO the bug is that af->data->nch should never be zero and the bug is
> elsewhere.

Why? (af_data_t*)arg->nch shouldn't but af->data->nch may not be
guaranteed to be nonzero. Actually all other filters initialize
af->data->nch upon REINIT.
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6