[MPlayer-dev-eng] [PATCH] dvdnav part 3 - emptyframe

[Michael Niedermayer]

Hi

On Tue, Jul 31, 2007 at 01:45:05AM +0200, elupus wrote:
> "Ötvös Attila" <oattila at chello.hu> wrote in message 
> news:200707301835.29057.oattila at chello.hu...
> >
> > I know. :(
> >
> > Since I work the dvdnav ever since I try to persuade the libmpeg2 to
> > decode still frame always.
> > I should be very glad if somebody should know a better solution.
> > I asked for help several times and this was born in my despond...
> >
> > Best regards.
> > Attila
> 
> The issue isn't with libmpeg2 asfar as I see it. I haven't checked mplayer's 
> demuxer, but lavf has had the issues for a long time. I have reported about 
> it as have a few others.
> If the stream doesn't go eof, lavf always search for the start of next image 
> to signify the end of the current one. Since the last thing the mpeg stream 
> contains in the case of stills is eof sequence, the parser never outputs 
> this to the decoder, it get's stuck in the demuxer.

please dont confuse the poor mortals here
the lavf demuxer does output the last frame if its followed by any
startcode be it SEQ_END_CODE or otherwise
its the decoder which may or may not output the last frame, iam not
sure if this has or has not been corrected
though attilas comments sound like it has been ...

your patch works because it injects SEQ_END_CODE like an additional frame
thus forcing the decoder to output the previous, this may very well be
a reasonable solution but i wont accept patches which are based on
complete lack of understanding the problem
i first would like that the patch submitter understands where the problem
is and why the patch works ...


also if theres a problem left at all i can fix that if you provide a proper
bugreport (that is testcase to reproduce the problem)




[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070731/fbe5fce5/attachment.pgp>