[MPlayer-dev-eng] [PATCH] dvdnav part 2 - still frames

[Diego Biurrun]

On Mon, Jul 30, 2007 at 02:40:49PM +0200, Ötvös Attila wrote:
> 
> 
> --- stream/stream_dvdnav.c	(revision 23928)
> +++ stream/stream_dvdnav.c	(working copy)
> @@ -163,10 +179,15 @@
>          return event;
>        case DVDNAV_STILL_FRAME: {
>          dvdnav_still_event_t *still_event = (dvdnav_still_event_t*)(buf);
> -        //if (priv->started) dvd_nav_still=1;
> -        //else
> -          dvdnav_still_skip(priv->dvdnav); // don't let dvdnav stall on this image
> -
> +        priv->still_length=still_event->length;
> +        if (priv->still_length!=255)                                // set still frame duration
> +            priv->duration = priv->still_length * 1000;
> +        else
> +            priv->duration = 0;
> +        if (priv->still_length==0x01) {                             // FIXME: TIME HACK
> +            pci_t* pnavpci = dvdnav_get_current_nav_pci( priv->dvdnav );
> +            priv->duration = dvdtimetomsec(&(pnavpci->pci_gi.e_eltm));

The rest of the file uses two spaces indentation, please respect that,
same below.

> --- mplayer.c	(revision 23928)
> +++ mplayer.c	(working copy)
> +    if(in_size<0) {                                     // is wait or still frame and no redecode last frame
> +        if (mpctx->last_buffer) {                       // free buffer

Nit: Please consistently place a space after if.

> --- command.c	(revision 23928)
> +++ command.c	(working copy)
> @@ -2760,9 +2760,12 @@
>  
>  		if (mp_dvdnav_handle_input
>  		    (mpctx->stream, cmd->args[0].v.i, &button)) {
> +// FIXME: if the mplayer returns from movie to still frame then the mplayer can't init the video codec
> +#if 0

s/the mplayer/MPlayer/g

Please break overly long lines.

Diego