[MPlayer-dev-eng] [PATCH] Remove global variables from tv.c
voroshil at gmail.com
Sun Jul 29 15:01:01 CEST 2007
2007/7/29, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> On Sun, Jul 29, 2007 at 02:58:39PM +0700, Vladimir Voroshilov wrote:
> > 2007/7/28, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > > On Sat, Jul 28, 2007 at 02:56:42PM +0700, Vladimir Voroshilov wrote:
> > > > 2007/7/22, Vladimir Voroshilov <voroshil at gmail.com>:
> > > > > I've tried to make global variables in tv.c context-dependant.
> > > > >
> > > > > Did i do this in right way?
> > > > > Is patch ok to commit?
> > > >
> > > > What about this patch ?
> > > > Can anybody say some words about it ?
> > >
> > > Well, it is an extremely huge patch. IMO it would have been much better
> > > to do it in several steps, introducing the priv thing, changing some
> > > trivial stuff, and esp. the options change in a seperate patch, since
> > > that is the largest part and not quite as obvious as some of the other
> > > changes.
> > >
> > Here is the result of splitting previous patch.
> It looks okay to me, assuming you tested it.
> Minor nit: I think you should use two spaces indentation for the members
> in the declaration of tv_param_t
Thanks for review.
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
More information about the MPlayer-dev-eng