[MPlayer-dev-eng] [PATCH] Teletext support try3 (complete set of patches)

Vladimir Voroshilov voroshil at gmail.com
Sun Jul 29 14:33:35 CEST 2007


2007/7/26, Vladimir Voroshilov <voroshil at gmail.com>:
> Hi, Michael
>
> 2007/7/22, Michael Niedermayer <michaelni at gmx.at>:
> > Hi
> >
> > On Sun, Jul 22, 2007 at 03:18:50AM +0700, Vladimir Voroshilov wrote:
> > > [...]
> > > To tell the truth current cache implementation is ugly.
> > > Unfortunately, i havn't neither enough knowledge nor ideas to make
> > > really good one.
> >
> > one improvement would be to replace the VBI_MAX_PAGES*VBI_MAX_SUBPAGES array
> > by a VBI_MAX_PAGES array of linked lists
> > so when you search for a specific entry you look at the spot in the array
> > corresponding to the page number and follow the linked list until you find
> > a matching sub page (or the end of the list)
> >
> > for inserting a new page into the cache you just add it into correspoding
> > linked list (at a random point like the begin)
> >
> > this would reduce the required memory without really affecting the speed as
> > the number of subpages is small
>
> Thanks for idea.
> I've implemented it.
>
> I will have no time till September for adding new features.
> Thus i want to finish working on this patch next five days.
> Here is complete set of patches.
>
> P.S. Diego already said that configure part is ok (and this part was
> not changed since that time). All issues noticed by Michael and Alban
> Bedel seems to be fixed.
>
> If no objections will be received, i'll commit this patch at Sunday.
>

I want to commit patch in 5 hours.
I anybody has objections or still wants to review it before commit
just say "don't commit yet" here :).

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719



More information about the MPlayer-dev-eng mailing list