[MPlayer-dev-eng] [RFC] make stream_read argument void*

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Wed Jul 25 20:38:36 CEST 2007


Hello,
currently we have quite few casts to avoid compiler complaints.
IMO the right way is to make stream_read make a void* argument.
Do you agree that something like this is the right thing to do:

Index: stream/stream.h
===================================================================
--- stream/stream.h     (revision 23859)
+++ stream/stream.h     (working copy)
@@ -205,7 +206,8 @@
   return y;
 }
 
-inline static int stream_read(stream_t *s,char* mem,int total){
+inline static int stream_read(stream_t *s,void *dst,int total){
+  char *mem = dst;
   int len=total;
   while(len>0){
     int x;


Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list