[MPlayer-dev-eng] Status of CoreAVC (last time) and using win32 codecs on x86_64

[Attila Kinali]

On Wed, 25 Jul 2007 12:12:00 +0200 (CEST)
Mikael Abrahamsson <swmike at swm.pp.se> wrote:

> On Wed, 25 Jul 2007, Attila Kinali wrote:
> 
> > Send a patch, or if you are not a coder test and review patches.
> > Alan Nisota did send patches, but for some reason they were not
> > accepted. My guess is that the most probable reason is that none of
> > the developers had enough interest and time to review them. So,
> > if you desperately want coreavc support, then help developing it.
> 
> I have tried his patches and they work. I stated so in my email. I have it 
> working off of an mplayer svn from a few months ago.

Sorry, but trying without reporting back doesn't help anyone.
Beside, the problem we have is that our developers do not have
enough time to review every patch that comes in. Doing a patch
review, even of a small patch takes easily an hour, larger
patches exponentially more. Then multiply that by the amount of
patches received. Now compare that with the amount of free
time a developer has beside school/work/familly/friends.
Not to take into account that reviewing patches is a tedious
and unrewarding work which more often than not leads to no
positiv feedback from the patch author (to put it in friendly ways).
 
> Why would someone put time and effort into trying again unless it's 
> specifically stated what Alan Nisota did that people didn't like? Only 
> thing I've seen so far has more to do with politics and vision than actual 
> code, so let's clear that problem first.

Human interaction is always nothing but politics.

> If someone says that the politics has been cleared and it's a code 
> problem, I'll happily spend time on testing the code.

I somehow have the impression that you have a wrong picture
of how work is done around here.

The only thing that matters around here is the code that has been
commited to the svn repo at the end of the day. It has to be clean,
(mostly) bugfree and shouldn't have any license problems. Anything
else, especially those things that you seem to call politics are
of second priority.

But the people here can only do so much. Time is precious (literaly),
if you want something from us, then you have to ask us in a way
that might motivate us. In the context of patches that means to
split it into as small and easy to review pieces as possible that
follow our guidelines as closly as possible.

Still a lot of patches that follow these rules get ignored here.
Why? Because the developers are not always interested to spend
time on a particular patch and wait for someone else to pick it up.
Sometimes this doesn't happen and the author doesn't ask himself.
Quite some time ago, i did the patch tracking here to make sure that
every patch got at least one response. But i don't have the time for
this anymore and although Diego tried to pick up the work, he didn't
last long and got swamped with other stuff.

<job advertisment>
So, if you want to help out, go trough the mailinglist and see
whether you can find patches that didn't get any reply and ask
for comments. That alone would help.
</job advertisment>


			Attila Kinali

-- 
Praised are the Fountains of Shelieth, the silver harp of the waters,
But blest in my name forever this stream that stanched my thirst!
                         -- Deed of Morred