[MPlayer-dev-eng] [PATCH] libdca support

[Aurelien Jacobs]

On Mon, 23 Jul 2007 22:16:08 +0200
Roberto Togni <rxt at rtogni.it> wrote:

> On Mon, 23 Jul 2007 11:38:13 -0500
> Amar Takhar <verm at darkbeer.org> wrote:
> 
> > On 2007-07-23 09:54 +0300, Uoti Urpala wrote:
> > > On Sun, 2007-07-22 at 12:48 +0200, Dominik 'Rathann' Mierzejewski wrote:
> > > > On Saturday, 21 July 2007 at 00:09, Amar Takhar wrote:
> > > > > One thing though: my build blows up due to libavcodec/dca.h existing, 
> > > > > that's a rather unfortunate name so the header needs to be renamed or 
> > > > > -I../libavformat removed from the compile line for ad_libdca.c so it won't 
> > > > > collide with the actual header from libdca.  I'm building on FreeBSD 7-CURRENT.
> > > > 
> > > > Doesn't happen on Linux with r23784. Please post configure.log, config.mak
> > > > and make log.
> > > 
> > > This is a difference between libdca versions. ad_libdca.c includes
> > > <dts.h>; that's the full header in libdca 0.0.2, but in current libdca
> > > svn it's a compatibility header which in turn includes <dca.h>. The
> > > libavcodec dca.h will break the build in the the latter case only.
> > 
> > Yeah, I should have mentioned that, however I'm running 0.0.5 which was released 
> > on 2007-04-10 -- 0.0.2 was released a year prior see 
> > http://download.videolan.org/pub/videolan/libdca/
> > 
> > The fix is the same though, it's probably better to rename dca.c/dca.h so dca.h 
> > won't collide now or in the future.
> > 
> 
> Ok, now I got the problem. I didn't even know about newer versions of
> the lib, the web page for libdca 
> http://download.videolan.org/developers/libdca.html still points to
> 0.0.2.
> 
> This looks like the same problem that happened with png.h, we can apply
> the same kind of workaround here, but if this problem get wider maybe
> it's better to look for a more general solution.
> Renaming dca.h is not an option, since it's not part of MPlayer and
> FFmpeg people do not seem too cooperative on the issue.

Because there is nothing to cooperate about.
dca.h is *not* a public header. MPlayer has no business setting -I to a
path containing the private dca.h file.
A sane solution would be to create a new directory to put ffmpeg's
public headers, and use -I only with this new directory.

Aurel