[MPlayer-dev-eng] [PATCH] change demuxer for radio from "rawaudio" to "audio"

Vladimir Voroshilov voroshil at gmail.com
Sun Jul 22 14:47:13 CEST 2007


2007/7/22, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sun, Jul 22, 2007 at 03:49:22PM +0700, Vladimir Voroshilov wrote:
>
> > +static int fill_wav_header(radio_priv_t* priv, char* buffer, int max_len){
>
> Use either void * or uint8_t * for generic data buffer, not char*

Ok

> > +    int fake_length=0; //real data length in WAV is unknown
>
> I think the right value for unknown is 0xffffffff, not 0.

testing of -dumpstream result.

With fake_length=0:
mplayer plays fine, shows correct end time of dumped (by -dumpstream) file.
aplay plays nothing
amarok plays fine, does not show end time at all

With fake_length=0xffffffff:
mplayer plays fine, always shows "9:19:14.0" as end time.
aplay plays fine
amarok plays fine, shows "9:19:14: as end time

I'll change fake_length to 0xffffffff

> And did you test how this works with -dumpstream/-dumpaudio?

-dumpstream produces playable wav file (see note about fake_length above)
-dumpaudio dumps raw audio data (without wave header)
Without this patch both options dumps only raw audio data.

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719



More information about the MPlayer-dev-eng mailing list