[MPlayer-dev-eng] [PATCH] libmpdemux code duplication

Diego Biurrun diego at biurrun.de
Tue Jul 17 18:49:40 CEST 2007


On Thu, Jul 05, 2007 at 07:58:06PM +0300, Uoti Urpala wrote:
> On Thu, 2007-07-05 at 15:00 +0200, Diego Biurrun wrote:
> > This is a small patch to get rid of some code duplication in libmpdemux
> > by moving some common definitions to demuxer.h.  Good to commit?
> 
> demuxer.h is included in a lot of files. I don't like including a big
> header like avcodec.h (3k lines) in all of them just to avoid including
> it individually in 3 files.

Yes, I've changed my mind about this.  However, do you think it makes
sense to move

#define FF_INPUT_BUFFER_PADDING_SIZE 8

to demuxer.h?

Diego



More information about the MPlayer-dev-eng mailing list