[MPlayer-dev-eng] [PATCH] segfault for fuzzed AAC (was 'segfault fix when parsing fuzzed ogg files')

[Nico Sabbi]

Attila Kinali wrote:

>On Tue, 10 Jul 2007 01:28:08 +0200
>Pierre Lombard <p_l at gmx.fr> wrote:
>
>  
>
>>* Pierre Lombard <p_l at gmx.fr> [2007-07-08 22:49]:
>>
>>    
>>
>>>I've just stumbled upon a few files at :
>>>  http://sam.zoy.org/zzuf/
>>>
>>>Every segfault reported there seems fixed in mplayer SVN but the 3
>>>following cases cause problems here :
>>>      
>>>
>>> => http://sam.zoy.org/zzuf/lol-mplayer.aac
>>>Segfaults - null pointer use (see attached log).
>>>      
>>>
>>Patch attached... but I've a vague feeling that it's not a proper fix
>>but a last-minute bandaid.
>>    
>>
>
>Any comments on this patch?
>
>			Attila Kinali
>  
>
workarounds for such unmaintened **** as faad
should be clearly marked so in the sources by comments,
or reviewers won't be able to make sense of them
 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 Prestiti personali fino a 30.000 Euro. Clicca qui per un preventivo immediato, richiedi subito l’importo e la rata che desideri!
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=6833&d=17-7