[MPlayer-dev-eng] [PATCH] Teletext support try3 (4/5, configure, slaves, etc)

Diego Biurrun diego at biurrun.de
Mon Jul 16 20:52:25 CEST 2007


On Tue, Jul 17, 2007 at 01:44:47AM +0700, Vladimir Voroshilov wrote:
>
> Check attached version.
>
> --- stream/Makefile	(revision 23790)
> +++ stream/Makefile	(working copy)
> @@ -51,6 +51,7 @@
>  SRCS_COMMON-$(TV_BSDBT848)       += tvi_bsdbt848.c
>  SRCS_COMMON-$(TV_V4L1)           += tvi_v4l.c  audio_in.c
>  SRCS_COMMON-$(TV_V4L2)           += tvi_v4l2.c audio_in.c
> +SRCS_COMMON-$(TV_TELETEXT)       += tvi_vbi.c

nit: alphabetical order

> --- configure	(revision 23790)
> +++ configure	(working copy)
> @@ -240,6 +240,7 @@
>    --disable-tv-v4l1      disable Video4Linux TV interface [autodetect]
>    --disable-tv-v4l2      disable Video4Linux2 TV interface [autodetect]
>    --disable-tv-bsdbt848  disable BSD BT848 interface [autodetect]
> +  --disable-tv-teletex   disable TV teletext interface [autodetect]

typo

> @@ -6702,7 +6706,24 @@
>  fi
>  echores "$_tv_v4l2"
>  
> +echocheck "TV teletext interface"

nit: Add an extra blank line please.

A man page update is missing, the rest of the stuff I maintain is OK.

Diego



More information about the MPlayer-dev-eng mailing list