[MPlayer-dev-eng] [PATCH] Teletext support try3 (1/5, core)

[Michael Niedermayer]

Hi

On Mon, Jul 16, 2007 at 12:31:59AM +0700, Vladimir Voroshilov wrote:
> 2007/7/15, Michael Niedermayer <michaelni at gmx.at>:
> > Hi
> >
> >
> > [...]
> > > +    case TV_VBI_CONTROL_SET_PAGE:
> > > +    {
> > > +        int val=*(int *) arg;
> > > +        if(val<0 || val>0x799)
> > > +            return TVI_CONTROL_FALSE;
> > > +        pthread_mutex_lock(&(priv_vbi->buffer_mutex));
> > > +        priv_vbi->pgno = steppage(0, val);
> >
> > this is wrong, if the user asks for page =0x7AB then you should return
> > that page and not another page
> >
> Quote from 2.1.4 of
> http://homepage.ntlworld.com/kryten_droid/teletext/spec/teletext_spec_1974.htm:
> =============QUOTE================
> Neither type of Page selection should respond to Page number 'Units'
> or 'Tens' in the range 10 to 15
> =============QUOTE================
> Should i totally ignore this or just return error instead of wrong
> page in case when user asking for 10-15 as one of digits?

please totally ignore it

you can send the KGB agents whos secret communication goes over these hidden
pages to me ;)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070715/ad8da132/attachment.pgp>