[MPlayer-dev-eng] [PATCH] Teletext support try3 (4/5, configure, slaves, etc)

[Vladimir Voroshilov]

2007/7/15, Vladimir Voroshilov <voroshil at gmail.com>:
> 2007/7/15, Alban Bedel <albeu at free.fr>:
> > On Sun, 15 Jul 2007 17:59:19 +0700
> > >  [skip]
> >
> > That's quiet a bit of code duplication, use a common function instead.
> > Also having PRINT for the mode, format and half_page properties would
> > be a nice addition.
> >
> Could you explain pls how code duplication can be removed.
> I see only one way: defining
> TV_VBI_CONTROL_STEP_* as TV_VBI_CONTROL_GET_* +1
> TV_VBI_CONTROL_SET_* as TV_VBI_CONTROL_GET_* +2 and so on.
> ("+<n>" is not neccesary, proper comment about values will be enough, imho).
>
> After that i can define proper TV_VBI_CONTROL_GET_* at property
> definition and add 0/1/2 constant to it at ioctl call.
>
> For such implementation one property handling routine will be enough.
>
> What will you say ?
>
> I'll try to add PRINT too.
Updated version (without PRINT yet) is attached.
-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tt29_iface.diff
Type: application/octet-stream
Size: 13838 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070715/1daa4152/attachment.obj>