[MPlayer-dev-eng] [PATCH] Teletext support try3 (1/5, core)

[Vladimir Voroshilov]

2007/7/15, Alban Bedel <albeu at free.fr>:
> On Sun, 15 Jul 2007 19:04:04 +0700
> "Vladimir Voroshilov" <voroshil at gmail.com> wrote:
>
> > Hi, Alban
> >
> > 2007/7/15, Alban Bedel <albeu at free.fr>:
> > > On Sun, 15 Jul 2007 18:01:13 +0700
> > > "Vladimir Voroshilov" <voroshil at gmail.com> wrote:
> > >
> > > > +    if(priv_vbi->on!=0 && priv_vbi->input_section==NULL) {
> > > > +        if (NULL==(tmp=mp_input_get_section())) tmp="default";
> > > > +        priv_vbi->input_section=strdup(tmp);
> > > > +        mp_input_set_section("teletext");
> > > > +    }
> > > > +    if(priv_vbi->on==0 && priv_vbi->input_section!=NULL) {
> > > > +        mp_input_set_section(priv_vbi->input_section);
> > > > +        free(priv_vbi->input_section);
> > > > +        priv_vbi->input_section=NULL;
> > > > +    }
> > >
> > > This is not acceptable, such UI related code doesn't belong in the
> > > stream layer.
> >
> > This is part of "<key> {<section>} <command>" feature support.
> > I can drop it out ("teletext" input section will be removed, but can
> > be replaced with "tv" section, though).
>
> Keep it, it is imho a very desirable feature. But the correct way is
> to make such change to the input mode from the property or command that
> enable/disable the teletext.
>
Done. Updated version is arrached.


-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tt29_core.diff
Type: application/octet-stream
Size: 47238 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070715/0fd969b8/attachment.obj>