[MPlayer-dev-eng] [PATCH] add support for subtitles thru lavf

[Aurelien Jacobs]

On Fri, 13 Jul 2007 16:46:15 +0200
Alban Bedel <albeu at free.fr> wrote:

> On Fri, 13 Jul 2007 15:59:25 +0200
> Aurelien Jacobs <aurel at gnuage.org> wrote:
> 
> > On Fri, 13 Jul 2007 15:45:40 +0200
> > Alban Bedel <albeu at free.fr> wrote:
> > 
> > > On Fri, 13 Jul 2007 14:29:45 +0200
> > > Aurelien Jacobs <aurel at gnuage.org> wrote:
> > > 
> > > > Hi,
> > > > 
> > > > The attached patch allows to display subtitles that are demuxed
> > > > by lavf.
> > > > Ok to apply ?
> > > 
> > > I would prefer if you replaced the explicit function call with a
> > > proper control. The whole subtitle stuff is enouth of a mess. It
> > > would be nicer if new feature where added "the right way" instead
> > > of adding more mess.
> > 
> > That would be better, but I don't feel motivated to do it right now.
> > So for now it works the same way as other demuxers.
> 
> You are adding yet another way to handle the subs, why not add the
> correct way right now?

No, I'm not. I'm just using the exact same methode as used in demux_mkv
or demux_ogg for example.

> It is realy just a matter of using control()
> instead of your own function, trivial. And it doesn't mean that you have
> to convert the other demuxers too. That would surely be welcome but that
> would belong into a separate patch anyway.

Well, ok, I may give it a try this weekend. But that is a separate issue,
and that shouldn't prevent this patch to go in.

Aurel