[MPlayer-dev-eng] [PATCH] add support for subtitles thru lavf

[Aurelien Jacobs]

On Fri, 13 Jul 2007 14:44:05 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> On Fri, Jul 13, 2007 at 02:29:45PM +0200, Aurelien Jacobs wrote:
> > 
> > The attached patch allows to display subtitles that are demuxed
> > by lavf.
> > Ok to apply ?
> 
> Didn't test the patch, but this is a very welcome feature!  One step
> closer to replacing native demuxers...
> 
> > --- libmpdemux/demux_lavf.c	(r??vision 23766)
> > +++ libmpdemux/demux_lavf.c	(copie de travail)
> > @@ -432,6 +435,17 @@
> > +        case CODEC_TYPE_SUBTITLE:{
> > +            sh_sub_t* sh_sub;
> > +            if(priv->sub_streams >= MAX_S_STREAMS)
> 
> nit: I prefer a space between if and the parentheses.

So do I. But I tried to be consistent with the rest of the file.

> > @@ -612,6 +632,19 @@
> >  
> > +/** \brief Get the language code for a subtitle track.
> > +
> > +  Retrieves the language code for a subtitle track.
> > +
> > +  \param demuxer The demuxer to work on
> > +  \param track_num The n'th subtitle track to get the language from
> 
> the subtitle track number to get the language from

Copy/paste without even reading is bad ;-)
Fixed.

Aurel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lavf_sub_2.diff
Type: text/x-diff
Size: 3469 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070713/cf07642f/attachment.diff>