[MPlayer-dev-eng] [PATCH] No need for snow and mpeg1encoder formplayer

[Ivan Kalvachev]

2007/7/11, Carl Eugen Hoyos <cehoyos at ag.or.at>:
> Hi!
>
> Michael Niedermayer <michaelni <at> gmx.at> writes:
>
> > > > you broke vf_uspp.c at least but probably more than just that
> > >
> > > What about disabling uspp (ultra slow seems like an understatement to me) and
> > > mcdeint for --disable-mencoder?
> >
> > i am fine with that if its properly documented
>
> -vf mcdeint and -vf uspp are IMO only useful with mencoder, (I'm not so sure
> about -vf spp that also crashes if certain encoders are not compiled in.) So
> perhaps it makes sense to disable them if --disable-mencoder was specified.
> Necessary would be to disable compilation of vf_mcdeint.c, vf_uspp.c and
> vf_spp.c and the calls to their inits in vf.c with a configure and Makefile
=^^^^^

Disable building of spp in MPlayer and you'll face my wrath!
There is absolutely no valid reason to disable it if mencoder is not enabled.
It works in realtime, gives best results and I DO use it exclusively
with MPlayer.

I also don't feel good about removing the other filters based on some
frivolous dependences, even if it is documented at page 666 in our
2007 page manual.

No bad feelings. ;)