[MPlayer-dev-eng] [PATCH] OS/2 Patches

[Alban Bedel]

On Wed, 11 Jul 2007 11:31:02 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> I don't really like this porting style at all.  Littering files with
> preprocessor conditionals is not a good solution.  Yes, I know that
> MPlayer is already full of code like this...

I'll second that, most of the #ifdef $SOME_OS should be replaced by
feature specific defines with corresponding check in configure when
needed. I wouldn't generaly oppose this patch, but imho it would make
more sense to take this patch as a base to try getting rid of most of
the OS specific defines (as it nicely point many of them).

	Albeu